Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal for chaning nodlet pkg/type name #21

Open
wants to merge 1 commit into
base: indigo
Choose a base branch
from
Open

proposal for chaning nodlet pkg/type name #21

wants to merge 1 commit into from

Conversation

k-okada
Copy link
Contributor

@k-okada k-okada commented Aug 23, 2016

format of nodelet_plugins.xml is

  <class name="example_pkg/MyNodeletClass" type="example_pkg::MyNodeletClass" base_class_type="nodelet::Nodelet">

http://wiki.ros.org/nodelet/Tutorials/Porting%20nodes%20to%20nodelets

If someonf is using nodelet already, this breaks API

@iory

@iory
Copy link
Contributor

iory commented Aug 23, 2016

+1 to me

@wkentaro
Copy link
Member

I agree with this change.
But this breaks the nodelet API, so I think you should release a version before merging this, and release a major version afterward.

This was referenced Aug 30, 2016
Closed
Merged
@wkentaro wkentaro mentioned this pull request Apr 10, 2017
Open
@wkentaro
Copy link
Member

See #59, it won't break API and just rename the nodelets.
We can break API after releasing the new API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
API Braking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@k-okada @iory @wkentaro