Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threshold #27

Merged
merged 6 commits into from Sep 2, 2016
Merged

Threshold #27

merged 6 commits into from Sep 2, 2016

Conversation

iory
Copy link
Contributor

@iory iory commented Aug 30, 2016

@iory iory force-pushed the threshold branch 6 times, most recently from c6550c3 to 33ebd30 Compare September 1, 2016 02:09
@k-okada
Copy link
Contributor

k-okada commented Sep 1, 2016

need rebase

@iory
Copy link
Contributor Author

iory commented Sep 1, 2016

rebased

<arg name="image" default="image" doc="The image topic. Should be remapped to the name of the real image topic." />

<arg name="use_camera_info" default="false" doc="Indicates that the camera_info topic should be subscribed to to get the default input_frame_id. Otherwise the frame from the image message will be used." />
<arg name="debug_view" default="true" doc="Specify whether the node displays a window to show edge image" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please support argument like
https://github.com/ros-perception/opencv_apps/blob/indigo/launch/edge_detection.launch#L9-L17

and put 1 node at launch file and for different threshold type example, put them within .test code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I fixed.
Please check it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, please concentrate on your RSJ work!

◉ Kei Okada

On Fri, Sep 2, 2016 at 7:17 PM, iory notifications@github.com wrote:

In launch/threshold.launch
#27 (comment)
:

@@ -0,0 +1,62 @@
+

OK, I fixed.
Please check it.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/ros-perception/opencv_apps/pull/27/files/9b2991aba7c3852c0f5cdb41ff59487b7d291d52#r77324505,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAeG3EBOBegZHJQJi0o4-6PGO0GB5ETGks5ql_e1gaJpZM4JwwZJ
.

@k-okada k-okada merged commit 39a5586 into ros-perception:indigo Sep 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants