-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zlib point cloud tranport plugin #5
Conversation
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! I had been brainstorming adding a general purpose compression algo like this. I have a few non-blocking comments.
Also do you have any stats on zlib's performance (comp/decomp speed and compression ratio?) on unorganized point cloud data?
|
||
#include <memory> | ||
#include <string> | ||
#include <unordered_map> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused
// Incoming data is invalid. | ||
return std::move(out_data_list); | ||
case Z_DATA_ERROR: | ||
case Z_MEM_ERROR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the node be informed of errors like this? Right now is it just going to fail silently?
ZlibPublisher::TypedEncodeResult ZlibPublisher::encodeTyped( | ||
const sensor_msgs::msg::PointCloud2 & raw) const | ||
{ | ||
gzip::Comp comp(gzip::Comp::Level::Level_7, true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compression level seems like a good candidate for dynamic configuration. But we could leave that as a future todo
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
No description provided.