Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planning Groups screen re-configured #1017

Merged

Conversation

mayman99
Copy link
Contributor

@mayman99 mayman99 commented Aug 6, 2018

Description

Planning Groups screen re-configured to solve spacing between items problems.

Checklist

  • Required: Code is auto formatted using clang-format
  • Include a screenshot if changing a GUI
  • Optional: Decide if this should be cherry-picked to other current ROS branches (Indigo, Jade, Kinetic)

@gavanderhoorn
Copy link
Contributor

Why are "joints" recommended? We typically use chains (especially for serial manipulators), and those also work 'best' with IK plugins.

@mayman99
Copy link
Contributor Author

mayman99 commented Aug 6, 2018

You have a point, but in this PR I honestly didn't look into the semantics. I just reconfigured the screen to look more cleaner than this

@gavanderhoorn
Copy link
Contributor

You're right. I assumed you had changed this.

Nevermind and sorry for the noise.

@mayman99
Copy link
Contributor Author

mayman99 commented Aug 6, 2018

Its okay 👍

@davetcoleman davetcoleman merged commit 417ecd6 into moveit:kinetic-devel Aug 6, 2018
@davetcoleman
Copy link
Member

cherry picked to melodic

@mayman99 mayman99 mentioned this pull request Aug 20, 2018
6 tasks
mayman99 added a commit to mayman99/moveit that referenced this pull request Aug 25, 2018
pull bot pushed a commit to shadow-robot/moveit that referenced this pull request Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants