Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed problem with jacobian of prismatic joints #1192

Merged
merged 1 commit into from
Nov 11, 2018
Merged

Fixed problem with jacobian of prismatic joints #1192

merged 1 commit into from
Nov 11, 2018

Conversation

ajsmilutin
Copy link
Contributor

Description

The need for changes is described in this issue report:
#1191

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extended the tutorials / documentation, if necessary reference
  • Include a screenshot if changing a GUI
  • Document API changes relevant to the user in the moveit/MIGRATION.md notes
  • Created tests, which fail without this PR reference
  • Decide if this should be cherry-picked to other current ROS branches
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@welcome
Copy link

welcome bot commented Nov 10, 2018

Thanks for helping in improving MoveIt!

rhaschke
rhaschke approved these changes Nov 11, 2018
View reviewed changes
Copy link
Contributor

@rhaschke rhaschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking this down!

@rhaschke rhaschke merged commit ece11fe into moveit:melodic-devel Nov 11, 2018
@welcome
Copy link

welcome bot commented Nov 11, 2018

Congrats on merging your first pull request and contributing to open source robotics!

@rhaschke rhaschke mentioned this pull request Nov 11, 2018
Closed
@ajsmilutin
Copy link
Contributor Author

ajsmilutin commented Nov 12, 2018 •
edited
Loading

@rhaschke no problem, it kind of solves my issues. But I guess this fix should be propagated to older branches. At least to kinetic which is where I've spotted the error. Is there a guideline for me to follow?
PS. This is my first PR, so I might be asking too much question

@rhaschke
Copy link
Contributor

Cherry-picked to Kinetic: 5041039

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhaschke rhaschke rhaschke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajsmilutin @rhaschke