Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix several issues in rendering of attached bodies in rviz plugins #1199

Merged
merged 5 commits into from
Nov 15, 2018

Conversation

rhaschke
Copy link
Contributor

@rhaschke rhaschke commented Nov 13, 2018

Rebase of #1152. Splitted into the basic fix (this PR) and the additional new feature providing a BoolProperty to switch attached bodies on/off (#1200).
This fixes #512.
Also added bug fixes for several other rendering issues I observed during testing the initial commit.
Look into individual commits for details.

@rhaschke rhaschke force-pushed the attached_object_visualization_fix branch from d45d6c8 to dadbbd9 Compare November 13, 2018 23:45
@rhaschke rhaschke requested a review from v4hn November 13, 2018 23:46
@rhaschke rhaschke changed the title Attached object visualization fix fix several issues in rendering of attached bodies in rviz plugins Nov 13, 2018
TrajectoryVisualization's attached-bodies were all colored with a hard-coded default.
@rhaschke rhaschke force-pushed the attached_object_visualization_fix branch from dadbbd9 to 73f7100 Compare November 14, 2018 09:30
@v4hn
Copy link
Contributor

v4hn commented Nov 15, 2018

Thank you for the fixes here @rhaschke @svenkrause !
I'll create a pull-request to backport to kinetic.

@v4hn v4hn merged commit 5026d99 into moveit:melodic-devel Nov 15, 2018
@rhaschke rhaschke deleted the attached_object_visualization_fix branch November 15, 2018 20:48
rhaschke added a commit that referenced this pull request Nov 15, 2018
fix several issues in rendering of attached bodies in rviz plugins
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants