Use correct trajectory_initialization_method param #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parameter updated for "trajectory_initialization_method" was `use_stochastic_descent_` instead, possibly due to a copy-paste leftover. This caused a segfault when trying to load this plugin with this parameter set, as the value of `params_.trajectory_initialization_method_` was never actually read.
|
Thanks for helping in improving MoveIt! |
|
Congrats on getting your first MoveIt! pull request merged and improving open source robotics! |
rhaschke
pushed a commit
that referenced
this pull request
Nov 28, 2018
hamalMarino
deleted the
hamalMarino/kinetic-fix_chomp_trajectory_initialization_method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The parameter updated for
"trajectory_initialization_method"wasuse_stochastic_descent_instead, possibly due to a copy-paste leftover.This caused a segfault when trying to load this plugin with this parameter set, as the value of
params_.trajectory_initialization_method_was never actually read.This should also be forward-ported to
melodic.Checklist