Travis: enable warnings and catkin_lint checker #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhaschke
force-pushed
the
enable-warnings
branch
from
8126913
to
c9ce258
Compare
davetcoleman
approved these changes
Feb 4, 2019
.travis.yml
Outdated
| @@ -1,6 +1,6 @@ | |||
| # This config file for Travis CI utilizes https://github.com/ros-planning/moveit_ci/ package. | |||
| sudo: required | |||
| dist: trusty | |||
| dist: xenial | |||
There was a problem hiding this comment.
Suggested change
| dist: xenial | |
| # This is the distro ran by Travis, which may or may not be what MoveIt! is tested against within Docker | |
| dist: xenial |
.travis.yml
Outdated
| @@ -13,12 +13,15 @@ notifications: | |||
| - 130s@2000.jukuin.keio.ac.jp | |||
| env: | |||
| global: | |||
| - MOVEIT_CI_TRAVIS_TIMEOUT=85 | |||
There was a problem hiding this comment.
Suggested change
| - MOVEIT_CI_TRAVIS_TIMEOUT=85 | |
| - MOVEIT_CI_TRAVIS_TIMEOUT=85 # Travis allows us 90 min but we add a safety margin to avoid timeouts |
.travis.yml
Outdated
| @@ -29,6 +32,9 @@ matrix: # Add a separate config to the matrix, using clang as compiler | |||
| env: ROS_REPO=ros-shadow-fixed | |||
| BEFORE_DOCKER_SCRIPT="source moveit_kinematics/test/test_ikfast_plugins.sh" | |||
|
|
|||
| allow_failures: | |||
| - env: TEST=catkin_lint | |||
There was a problem hiding this comment.
Suggested change
| - env: TEST=catkin_lint | |
| - env: TEST=catkin_lint # TODO: fix all catkin_lint errors in the future |
| @@ -1,5 +1,9 @@ | |||
| set(MOVEIT_LIB_NAME moveit_robot_state) | |||
|
|
|||
| if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang") | |||
There was a problem hiding this comment.
could you add a comment about why this is necessary please?
+ increase Travis timeout (90min - 5min margin) + update Travis distro to Xenial as suggested by Travis folks + add catkin_lint (currently failing)
- add missing parentheses - correct comparison operator
rhaschke
force-pushed
the
enable-warnings
branch
from
c9ce258
to
677265c
Compare
sjahr
pushed a commit
to sjahr/moveit
that referenced
this pull request
Jun 21, 2024
Co-authored-by: AndyZe <zelenak@picknik.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables more checkers in Travis using the new features of moveit/moveit_ci#45.
Fixes for clang warnings will immediately follow.