Fixed to handle normal robot urdf paths #1391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmagyar
suggested changes
Mar 12, 2019
moveit_core/utils/include/moveit/utils/robot_model_test_utils.h
Outdated
Show resolved
Hide resolved
rhaschke
approved these changes
Mar 12, 2019
|
PTAL, the comments have been addressed. |
|
Thanks for addressing the comments so quickly. Merged. |
rhaschke
pushed a commit
to ubi-agni/moveit
that referenced
this pull request
May 11, 2019
PR2 robot requires a different path then Fanuc and Panda.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #1386.
Fixes the fact robot URDF and SRDF paths were hardcoded to the non-standard PR2 locations. Now uses the PR2 as a non-standard if case, and uses the newer normal locations of URDF in
<robot>_description/urdf/<robot>.urdfand SRDF in<robot>_moveit_config/config/<robot>.srdf.Checklist