Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup launch + config files #1631

Conversation

rhaschke
Copy link
Contributor

  • Fix some names
  • Remove empty trailing lines in .yaml
  • Group pipeline configs in a <group ns> node in .launch files.

@rhaschke
Copy link
Contributor Author

@henningkayser, do you plan to file more PRs to this feature branch in the very next future?
If not, I think it's time to merge into master. 🎉

@henningkayser
Copy link
Member

@rhaschke thanks for fixup, also good hint about using <group ns> here.
I don't plan about adding new related features for now and would be happy with merging into master.

@henningkayser henningkayser merged commit 39171c8 into moveit:feature-benchmark-improvements Aug 21, 2019
@rhaschke rhaschke deleted the feature-benchmark-improvements branch August 22, 2019 07:47
@rhaschke
Copy link
Contributor Author

Merged feature-benchmark-improvements into master.

henningkayser pushed a commit to PickNikRobotics/moveit that referenced this pull request Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants