Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[melodic-devel] change FloatingJointModel::getStateSpaceDimension return value to 7 #2106

Conversation

tylerjw
Copy link
Member

@tylerjw tylerjw commented May 24, 2020

Description

Backport of bugfix from #2031

@v4hn asked for this here: #2066

I didn't include the test that came with this. LMK if you think I should backport that too.

@tylerjw tylerjw mentioned this pull request May 24, 2020
20 tasks
@codecov-commenter
Copy link

Codecov Report

Merging #2106 into melodic-devel will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           melodic-devel    #2106      +/-   ##
=================================================
- Coverage          51.82%   51.80%   -0.03%     
=================================================
  Files                320      320              
  Lines              24459    24459              
=================================================
- Hits               12677    12670       -7     
- Misses             11782    11789       +7     
Impacted Files Coverage Δ
...veit_core/robot_model/src/floating_joint_model.cpp 48.35% <100.00%> (ø)
.../ompl_interface/src/detail/constrained_sampler.cpp 46.15% <0.00%> (-17.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d21bf86...6885ae7. Read the comment docs.

@v4hn v4hn merged commit 09727a4 into moveit:melodic-devel May 25, 2020
sjahr pushed a commit to sjahr/moveit that referenced this pull request Jun 21, 2024
moveit#2106)

* Change variable names for improved readability

* Update comments

* Fix typo

* Fix issues from rebase

* Remove declaration for updateJoints()

* Update comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants