-
Notifications
You must be signed in to change notification settings - Fork 938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEM: fix check for start state position #2157
Conversation
distance() respects unlimited revolute joints
Codecov Report
@@ Coverage Diff @@
## master #2157 +/- ##
==========================================
- Coverage 58.27% 57.92% -0.36%
==========================================
Files 327 327
Lines 24707 25640 +933
==========================================
+ Hits 14399 14853 +454
- Misses 10308 10787 +479
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I am kind of surprised this has gone unnoticed for so long.
On Wed, Jun 24, 2020 at 09:35:35AM -0700, Mark Moll wrote:
Looks good to me. I am kind of surprised this has gone unnoticed for so long.
Well, it *is* a damn unlikely edge case to have a
- continuous joint
- start planning from its range edge
- have noise move the joint to the other side in the meanwhile
Thanks for merging.
We should look through backports again soon and merge this also back to `kinetic-devel`, as requested by the reporting user.
|
distance() respects unlimited revolute joints
distance() respects unlimited revolute joints
distance() respects unlimited revolute joints
distance() respects unlimited revolute joints
Addresses an issue pointed out in #694 .