Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEM: fix check for start state position #2157

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

v4hn
Copy link
Contributor

@v4hn v4hn commented Jun 21, 2020

distance() respects unlimited revolute joints

Addresses an issue pointed out in #694 .

distance() respects unlimited revolute joints
@codecov
Copy link

codecov bot commented Jun 21, 2020

Codecov Report

Merging #2157 into master will decrease coverage by 0.35%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2157      +/-   ##
==========================================
- Coverage   58.27%   57.92%   -0.36%     
==========================================
  Files         327      327              
  Lines       24707    25640     +933     
==========================================
+ Hits        14399    14853     +454     
- Misses      10308    10787     +479     
Impacted Files Coverage Δ
...ution_manager/src/trajectory_execution_manager.cpp 47.75% <100.00%> (ø)
.../move_group_interface/src/move_group_interface.cpp 48.07% <0.00%> (-51.93%) ⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp 70.10% <0.00%> (-0.15%) ⬇️
...veit_experimental/moveit_jog_arm/src/jog_calcs.cpp 71.35% <0.00%> (+0.25%) ⬆️
...moveit/move_group_interface/move_group_interface.h 60.00% <0.00%> (+2.10%) ⬆️
.../ompl_interface/src/detail/constrained_sampler.cpp 64.10% <0.00%> (+17.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e4a164...b6a6bb9. Read the comment docs.

@v4hn v4hn added awaits 2nd review one maintainer approved this request bug labels Jun 22, 2020
@mamoll mamoll self-requested a review June 24, 2020 16:34
Copy link
Contributor

@mamoll mamoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I am kind of surprised this has gone unnoticed for so long.

@mamoll mamoll merged commit 4f9531d into moveit:master Jun 24, 2020
@v4hn
Copy link
Contributor Author

v4hn commented Jun 24, 2020 via email

rhaschke pushed a commit that referenced this pull request Jun 25, 2020
distance() respects unlimited revolute joints
rhaschke pushed a commit that referenced this pull request Jun 25, 2020
distance() respects unlimited revolute joints
@tylerjw tylerjw mentioned this pull request Jul 18, 2020
20 tasks
pull bot pushed a commit to shadow-robot/moveit that referenced this pull request Sep 3, 2020
distance() respects unlimited revolute joints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits 2nd review one maintainer approved this request bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants