Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfault in PSM::clearOctomap() #2193

Merged
merged 1 commit into from
Jul 6, 2020

Conversation

henningkayser
Copy link
Member

I randomly ran into this, the warning message should be self-explanatory.

@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #2193 into master will increase coverage by 0.42%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2193      +/-   ##
==========================================
+ Coverage   57.69%   58.11%   +0.42%     
==========================================
  Files         326      326              
  Lines       25661    24730     -931     
==========================================
- Hits        14805    14372     -433     
+ Misses      10856    10358     -498     
Impacted Files Coverage Δ
...nning_scene_monitor/src/planning_scene_monitor.cpp 69.89% <0.00%> (-0.66%) ⬇️
...moveit/move_group_interface/move_group_interface.h 57.89% <0.00%> (-2.11%) ⬇️
...ipulation/pick_place/src/manipulation_pipeline.cpp 76.41% <0.00%> (-0.95%) ⬇️
...raint_samplers/src/default_constraint_samplers.cpp 82.54% <0.00%> (-0.37%) ⬇️
moveit_core/robot_state/src/robot_state.cpp 47.39% <0.00%> (+0.09%) ⬆️
...meterization/work_space/pose_model_state_space.cpp 82.99% <0.00%> (+0.68%) ⬆️
...on/pick_place/src/approach_and_translate_stage.cpp 73.60% <0.00%> (+0.79%) ⬆️
...anning_scene_monitor/src/current_state_monitor.cpp 52.82% <0.00%> (+1.53%) ⬆️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 79.37% <0.00%> (+2.69%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0274ea9...0d46eff. Read the comment docs.

Copy link
Member

@tylerjw tylerjw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, it is good to test before using

@rhaschke rhaschke merged commit 538d15f into moveit:master Jul 6, 2020
rhaschke pushed a commit that referenced this pull request Aug 13, 2020
@rhaschke rhaschke mentioned this pull request Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants