Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace panda_moveit_config -> moveit_resources_panda_moveit_config #2300

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

rhaschke
Copy link
Contributor

@rhaschke rhaschke commented Sep 8, 2020

This fixes a failing test on the ROS buildfarm: http://build.ros.org/job/Ndev__moveit__ubuntu_focal_amd64/1

Copy link
Contributor

@jschleicher jschleicher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #2300 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2300      +/-   ##
==========================================
- Coverage   57.92%   57.90%   -0.02%     
==========================================
  Files         327      327              
  Lines       25644    25645       +1     
==========================================
- Hits        14853    14847       -6     
- Misses      10791    10798       +7     
Impacted Files Coverage Δ
.../ompl_interface/src/detail/constrained_sampler.cpp 46.16% <0.00%> (-17.94%) ⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp 69.45% <0.00%> (-0.44%) ⬇️
...raint_samplers/src/default_constraint_samplers.cpp 84.00% <0.00%> (-0.36%) ⬇️
...t_setup_assistant/src/tools/moveit_config_data.cpp 20.25% <0.00%> (-0.02%) ⬇️
...ipulation/pick_place/src/manipulation_pipeline.cpp 78.31% <0.00%> (+0.95%) ⬆️
...eit_ros/manipulation/pick_place/src/pick_place.cpp 92.24% <0.00%> (+3.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cc3633...9dfb945. Read the comment docs.

Copy link
Contributor

@v4hn v4hn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@rhaschke did you check why this did not trigger in our own CI?

@v4hn v4hn merged commit 8771af6 into moveit:master Sep 8, 2020
@rhaschke rhaschke deleted the fix-ros-build-farm-issues branch September 9, 2020 19:36
@tylerjw tylerjw mentioned this pull request Oct 23, 2020
57 tasks
@JafarAbdi JafarAbdi mentioned this pull request Mar 11, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants