Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows CI #2776

Merged
merged 1 commit into from
Jul 17, 2021
Merged

Fix Windows CI #2776

merged 1 commit into from
Jul 17, 2021

Conversation

rhaschke
Copy link
Contributor

Fixes error C2338:

You've instantiated std::aligned_storage<Len, Align>
with an extended alignment (in other words, Align > alignof(max_align_t)).
Before VS 2017 15.8, the member type would non-conformingly have an
alignment of only alignof(max_align_t).
VS 2017 15.8 was fixed to handle this correctly, but the fix inherently
changes layout and breaks binary compatibility (*only* for uses of
aligned_storage with extended alignments). Please define either
1. _ENABLE_EXTENDED_ALIGNED_STORAGE to acknowledge that you understand
    this message and that you actually want a type with an extended alignment
2. _DISABLE_EXTENDED_ALIGNED_STORAGE to silence this message and
    get the old non-conformant behavior.

Fix error C2338: You've instantiated std::aligned_storage<Len, Align>
with an extended alignment (in other words, Align > alignof(max_align_t)).
Before VS 2017 15.8, the member type would non-conformingly have an
alignment of only alignof(max_align_t).
VS 2017 15.8 was fixed to handle this correctly, but the fix inherently
changes layout and breaks binary compatibility (*only* for uses of
aligned_storage with extended alignments). Please define either
(1) _ENABLE_EXTENDED_ALIGNED_STORAGE to acknowledge that you understand
    this message and that you actually want a type with an extended alignment
(2) _DISABLE_EXTENDED_ALIGNED_STORAGE to silence this message and
    get the old non-conformant behavior.
@rhaschke rhaschke requested a review from v4hn as a code owner July 17, 2021 15:54
@rhaschke rhaschke merged commit bec399a into moveit:master Jul 17, 2021
@rhaschke rhaschke deleted the fix-windows-ci branch July 17, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant