Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bullet plugin library path name #2783

Merged
merged 1 commit into from
Jul 21, 2021

Conversation

captain-yoshi
Copy link
Contributor

Description

Fix wrong plugin library path for the Bullet collision detector.

Exception while loading Bullet: Could not find library corresponding to plugin Bullet. Make sure the plugin description XML file has the correct name of the library and that the library actually exists.

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #2783 (fb89392) into master (a27e5d1) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2783      +/-   ##
==========================================
- Coverage   60.48%   60.46%   -0.01%     
==========================================
  Files         366      366              
  Lines       31654    31654              
==========================================
- Hits        19142    19138       -4     
- Misses      12512    12516       +4     
Impacted Files Coverage Δ
.../ompl_interface/src/detail/constrained_sampler.cpp 43.25% <0.00%> (-16.21%) ⬇️
...meterization/work_space/pose_model_state_space.cpp 81.14% <0.00%> (-1.88%) ⬇️
...g_scene_interface/src/planning_scene_interface.cpp 47.46% <0.00%> (-1.12%) ⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp 68.27% <0.00%> (+0.14%) ⬆️
...raint_samplers/src/default_constraint_samplers.cpp 80.72% <0.00%> (+0.30%) ⬆️
...ipulation/pick_place/src/manipulation_pipeline.cpp 72.23% <0.00%> (+0.93%) ⬆️
..._interface/src/detail/constrained_goal_sampler.cpp 76.00% <0.00%> (+2.00%) ⬆️
...eit_ros/manipulation/pick_place/src/pick_place.cpp 92.64% <0.00%> (+3.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a27e5d1...fb89392. Read the comment docs.

@rhaschke
Copy link
Contributor

Don't we have a unit test using the bullet collision???

@rhaschke rhaschke merged commit 4d1198e into moveit:master Jul 21, 2021
@captain-yoshi
Copy link
Contributor Author

Yes there is but, to my knowledge, there are no test using bullet through the collision_detection::CollisionPlugin. I think it's the same for FCL.

This PR from reach added a test for the same issue. It could give ideas on how to create a test for Bullet and FCL through the plugin. Maybe MoveIt has already tests that uses a plugin (Kinematics, planning).

@rhaschke
Copy link
Contributor

I suggest adapting the existing tests to load the collision library via the plugin mechanism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants