Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[moveit_core] Fix export of FCL dependency #2819

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Conversation

jspricke
Copy link
Contributor

Regression of 93c3f63
Closes: #2804

@jspricke
Copy link
Contributor Author

This is a little hacky but according to someone who does not want to be named "should work", alternatively we could export the target but EXPORTED_TARGETS in catkin did not work or use CFG_EXTRAS...

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #2819 (094743b) into master (6e798bf) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2819      +/-   ##
==========================================
- Coverage   60.82%   60.81%   -0.00%     
==========================================
  Files         366      366              
  Lines       31713    31713              
==========================================
- Hits        19285    19283       -2     
- Misses      12428    12430       +2     
Impacted Files Coverage Δ
...meterization/work_space/pose_model_state_space.cpp 81.14% <0.00%> (-1.88%) ⬇️
...ipulation/pick_place/src/manipulation_pipeline.cpp 69.45% <0.00%> (-1.85%) ⬇️
...g_scene_interface/src/planning_scene_interface.cpp 47.46% <0.00%> (-1.12%) ⬇️
...on/pick_place/src/approach_and_translate_stage.cpp 73.38% <0.00%> (-0.64%) ⬇️
...dl_kinematics_plugin/src/kdl_kinematics_plugin.cpp 77.87% <0.00%> (-0.38%) ⬇️
...nning_scene_monitor/src/planning_scene_monitor.cpp 68.27% <0.00%> (+0.14%) ⬆️
.../ompl_interface/src/detail/constrained_sampler.cpp 59.46% <0.00%> (+16.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e798bf...094743b. Read the comment docs.

@v4hn
Copy link
Contributor

v4hn commented Aug 17, 2021

Thanks for finding the culprit. half-exporting the target explains the behavior... I remember we previously used CFG_EXTRAS for Boost components somewhere, but I can't find it anymore.

I don't particularly like the solution because other libraries might follow in the future, but it's good enough for now. Thank you!

@v4hn v4hn merged commit 4d6f805 into moveit:master Aug 17, 2021
@jspricke jspricke deleted the fix_fcl branch December 22, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

moveit_ros_planning fails to build with DCMAKE_BUILD_TYPE=Debug
4 participants