Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for (#2824) #2843

Closed
felixvd opened this issue Aug 26, 2021 · 4 comments
Closed

Add test for (#2824) #2843

felixvd opened this issue Aug 26, 2021 · 4 comments
Labels
enhancement good first issue If you want to contribute work for the first time, look at this

Comments

@felixvd
Copy link
Contributor

felixvd commented Aug 26, 2021

#2824 fixed a bug with the pilz industrial motion planner, where attached objects were not considered during plans.

It would be very helpful if this bug was covered by a test, for example with a motion like in this tutorial:

image

This is a good issue for someone new. You only need to add a test, e.g. in one of these files or a new one, which fails before the PR and succeeds after.

You can run your test with catkin run_tests -iv or rostest your_package your_test_file as described here. If you are a new contributor, feel free to ask for help in this thread.

@felixvd felixvd added enhancement good first issue If you want to contribute work for the first time, look at this labels Aug 26, 2021
@ghost
Copy link

ghost commented Sep 15, 2021

hey felix i am new to ros learned about moveit through sense think and act podcast really intrested in doing some open source work can you guide me how can i help solve this issue.

@felixvd
Copy link
Contributor Author

felixvd commented Sep 15, 2021

Hi,

I would suggest to start by following the tutorials, asking on ROS Answers if you have trouble with anything, then move on to read and understand the code as much as possible, try to build it from source, then write some new tests and check if they succeed.

@cambel cambel mentioned this issue Sep 19, 2021
6 tasks
@gquey
Copy link

gquey commented Jan 21, 2022

Hello, is this issue still open? I am looking to make my first contribution and this looks like a good place to start. Thanks

@rhaschke
Copy link
Contributor

As you can see from the latest linked PR, this issue was already fixed in #2878.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue If you want to contribute work for the first time, look at this
Projects
None yet
Development

No branches or pull requests

3 participants