Replace const_cast with static_cast where possible #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v4hn
approved these changes
Jan 30, 2017
This was referenced Jan 30, 2017
|
Heh, I did not expect that one letter size difference to matter, but obviously it does :) I'll wait for CI to pass on all branches and then merge all of them. Probably tomorrow morning. |
|
All checks passed, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
const_castwithstatic_castwhere possible. Aconst_castis normally an indication of an API problem somewhere. The replaced casts only addconst, so astatic_castwill do just fine, with the added benefit that it doesn't look like dangerous things are happening.Should be fine to pick to I/J. No API or ABI changes.