Fixing warehouse services #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrgnicho
reviewed
Mar 21, 2017
| ROS_INFO("Connecting to warehouse on %s:%d", host.c_str(), port); | ||
| if (!conn->connect()) | ||
| { | ||
| ROS_ERROR("Failed to connect to DB"); |
There was a problem hiding this comment.
It'd be nice to print the host and port on this error message. I'm surprised it ever worked without the call to connect()
|
@jrgnicho thanks for reviewing it. I added info to the comment. |
|
Thanks for the contribution @beatrizleon ! |
|
@v4hn thanks for the merge! Do you have an estimate on when these changes will be released to the deb package? |
|
On Wed, Mar 22, 2017 at 05:31:47AM -0700, Beatriz Leon wrote:
@v4hn thanks for the merge! Do you have an estimate on when these changes will be released to the deb package?
@130s is in charge of the release process.
We had a release just two weeks ago (f3b6a04).
Personally, I would like to wait with the next one until we accumulated some more fixes or other interesting additions (maximum another month).
If you need this fix sooner or another maintainer wants a release sooner, we could have another patch release though, I guess.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When launching the warehouse services, I got an error connecting to the warehouse which was due to not having the appropriate try/catch and also missing the conn->connect() call. With this pr, services are advertised correctly.
Checklist
Thank you!