Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collision_detection::World::moveObject() #957

Merged
merged 1 commit into from
Jun 25, 2018

Conversation

rhaschke
Copy link
Contributor

Provide a convienency method to move all shapes of a collision object. Before, for all shapes shapes we had to call moveShapeInObject(), which created overhead for finding the object over and over.

@v4hn v4hn merged commit d3d8887 into moveit:kinetic-devel Jun 25, 2018
v4hn pushed a commit that referenced this pull request Jun 25, 2018
@v4hn
Copy link
Contributor

v4hn commented Jun 25, 2018

Thanks, makes sense to add.
Merged and picked to melodic.

May I ask in what context you use these interfaces?
Adding things to the collision world directly is quite low-level and having more than one shape in an object does not behave very nice in other places either, so I'm wondering.

@rhaschke
Copy link
Contributor Author

I used this function to fix initial collisions of objects spawned from our vision pipeline. Due to bad fitting and or bad camera-robot calibration, these objects might collide with the table.
In my case, I have direct access to a PlanningScene and thus the underlying World object.

@rhaschke rhaschke deleted the moveObject branch July 4, 2018 07:28
dg-shadow pushed a commit to shadow-robot/moveit that referenced this pull request Jul 30, 2018
mayman99 pushed a commit to mayman99/moveit that referenced this pull request Aug 25, 2018
rhaschke added a commit to ubi-agni/moveit that referenced this pull request Oct 20, 2018
rhaschke added a commit that referenced this pull request Oct 25, 2018
rhaschke added a commit that referenced this pull request Oct 25, 2018
pull bot pushed a commit to shadow-robot/moveit that referenced this pull request Sep 3, 2020
JafarAbdi pushed a commit to JafarAbdi/moveit that referenced this pull request Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants