New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cherry picking from Kinetic #1160
Conversation
11e9d1a
to
2e6f28f
Compare
@@ -45,6 +45,8 @@ | |||
#include <moveit/ompl_interface/constraints_library.h> | |||
#include <moveit/kinematic_constraints/utils.h> | |||
#include <moveit/profiler/profiler.h> | |||
#include <moveit/utils/lexical_casts.h> | |||
#include <eigen_conversions/eigen_msg.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This extra include introduces a regression in melodic-devel
:
http://build.ros.org/view/Mbin_uB64/job/Mbin_uB64__moveit_planners_ompl__ubuntu_bionic_amd64__binary/17/console
We removed the eigen_conversions
tf1 dependency in #830
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Argh! Can you device a fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! This is a spurious include. It's as simple as removing that line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just have seen #1174 fixes the issue (hopefully).
moveit_planners_ompl had a a Melodic buildfarm failure this morning: http://build.ros.org/view/Mbin_uB64/job/Mbin_uB64__moveit_planners_ompl__ubuntu_bionic_amd64__binary/17/ This commit removes an unneeded include from #1160
Please use rebase-commit to merge!