Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test #1261

Merged
merged 2 commits into from Dec 12, 2018

Conversation

Projects
None yet
2 participants
@rhaschke
Copy link
Collaborator

commented Dec 11, 2018

Fixes #1259.
The culprit was the change in memory management of shared objects, deleting tf2::Buffer and it's associated tf2::TransformListener together - but unfortunately in the wrong order.

This also cleans up the corresponding unittests.

@rhaschke rhaschke requested a review from v4hn Dec 11, 2018

rhaschke added some commits Dec 11, 2018

cleanup tests
- avoid installing tests
- rename test_cleanup.cpp / test_cleanup.py
- increase robustness of cleanup tests: run 5 times

@rhaschke rhaschke force-pushed the ubi-agni:fix-flaky-test branch from 3969511 to 6e7bdc2 Dec 12, 2018

@v4hn

This comment has been minimized.

Copy link
Member

commented Dec 12, 2018

...
Thanks for the fast fixup.

@v4hn v4hn merged commit 1d78df5 into ros-planning:melodic-devel Dec 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@v4hn

This comment has been minimized.

Copy link
Member

commented Dec 12, 2018

As we were talking about hot-fix releases the other day, I guess, we should do one for this?
This can trigger segfaults in existing code.

@rhaschke

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 12, 2018

I think so too. There is another severe regression, which I want to address: #1255. Any help is welcome!

@v4hn

This comment has been minimized.

Copy link
Member

commented Dec 13, 2018

There is another severe regression, which I want to address: #1255. Any help is welcome!

As I just argued there, I think this might require additional API / a novel concept introduced to MoveIt.

I don't think we should wait for this with the fixup release.

@rhaschke

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 13, 2018

As I just argued there, I think this might require additional API / a novel concept introduced to MoveIt.

I don't agree.

I don't think we should wait for this with the fixup release.

I agree. I can trigger a new release this evening.

@rhaschke rhaschke deleted the ubi-agni:fix-flaky-test branch Dec 13, 2018

@rhaschke rhaschke referenced this pull request Dec 13, 2018

Closed

201811 release #1225

11 of 12 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.