allow multiple eefs per planning group #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to an early escape from the loop (after the first found eef for a group), MoveIt! wasn't aware of other eef names (with possibly a different parent_link) associated to a group.
jonbinney
suggested changes
Feb 14, 2019
| * \brief Get a vector of end effector tips included in a particular joint model group as defined by the SRDF end | ||
| * effector semantic | ||
| * \brief Get the unique set of end effector tips included in a particular joint model group | ||
| * as defined by the SRDF end effector semantic |
There was a problem hiding this comment.
Wording suggestion - since "SRDF" already has "semantic" in it, you can remove the "effector semantic" part at the end of this sentence. Alternatively you could say "by SRDF end_effector elements"
There was a problem hiding this comment.
Thanks for this suggestion. Please consider to use github's suggestion mechanism in future. The facilitates integrating these changes.
| * \brief Get a vector of end effector tips included in a particular joint model group as defined by the SRDF end | ||
| * effector semantic | ||
| * \brief Get the unique set of end effector tips included in a particular joint model group | ||
| * as defined by the SRDF end effector semantic |
There was a problem hiding this comment.
Same wording suggestion as above.
... changing the API from std::vector to std::set
rhaschke
force-pushed
the
allow-multiple-eefs
branch
from
886d54f
to
324c5d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an early escape from the loop (after the first found eef for a group), MoveIt!
wasn't aware of other eef names (with possibly a different
parent_link) associated to a group.