-
Notifications
You must be signed in to change notification settings - Fork 936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate PRBT ikfast plugin from moveit_resources #2697
Conversation
This circumnavigates problems with running tests in the moveit repository that are based on this plugin. Before, this plugin was part of moveit_resources, but introduced a compile time dependency on moveit_core. Because a repository's tests should run without having to compile downstream code (a sane requirement on buildfarm/prerelease tests), we move the plugin here instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As said before, I do not support moving a specific IKfast planner into the moveit_kinematics
package, which should provide generic
interfaces only.
Additionally, as pointed out in moveit/moveit_resources#79 (comment), moving the IK plugin into moveit_kinematics
, will not resolve the issue that moveit_resources
depends on moveit_kinematics
.
If that is the only alternative solution we can come up with, I would prefer the current solution, pulling both moveit
and moveit_resources
into the target workspace of GHA (and accept the broken prerelease + build farm test).
for autogenerated file...
We could put it in a separate ROS package in the repository if that's your main concern. |
Codecov Report
@@ Coverage Diff @@
## master #2697 +/- ##
==========================================
- Coverage 60.62% 60.51% -0.11%
==========================================
Files 402 402
Lines 29615 29615
==========================================
- Hits 17952 17918 -34
- Misses 11663 11697 +34
Continue to review full report at Codecov.
|
Closing as we decided to take a different approach. |
As announced in #2653 (comment) .
Together with moveit/moveit_resources#79 this is supposed to provide a straight-forward solution for #2653 .
Moving the plugin here circumnavigates problems with running tests in the moveit repository that are based on it. Before, this plugin was part of moveit_resources, but introduced a compile time dependency on moveit_core.
Because a repository's tests should run without having to compile downstream code (a sane requirement on buildfarm/prerelease tests), we move the plugin here instead.