address gcc6 build error #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 24, 2017 16:42
With gcc6, compiling fails with `stdlib.h: No such file or directory`, as including '-isystem /usr/include' breaks with gcc6, cf., https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129. This commit addresses this issue for this package in almost the same way it was addressed in various other ROS packages. A list of related commits and pull requests is at: ros/rosdistro#12783 Particularly when searching for the Boost library CMake sets Boost_INCLUDE_DIRS to @sysRoot@/usr/include which should be avoided in the `-isystem` option of gcc. The same goes for OpenCV. Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@linux.intel.com>
Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@linux.intel.com>
|
Added two more commits:
|
de-vri-es
suggested changes
Jan 25, 2017
de-vri-es
suggested changes
Jan 25, 2017
| @@ -63,7 +63,7 @@ void planning_scene_monitor::TrajectoryMonitor::setSamplingFrequency(double samp | |||
|
|
|||
| bool planning_scene_monitor::TrajectoryMonitor::isActive() const | |||
| { | |||
| return record_states_thread_; | |||
| return !!record_states_thread_.get(); | |||
There was a problem hiding this comment.
On the kinetic-devel branch this is currently already fixed as return static_cast<bool>(record_states_thread_); Not sure why we didn't backport it, but I think it's best to use the same fix here too.
There was a problem hiding this comment.
Good catch. static_cast would be much better here. Will fix!
When building with gcc6.2 and hardened compiler options used in Ostro project the build fails with the following error: moveit-ros-planning/moveit_ros/planning/planning_scene_monitor /src/trajectory_monitor.cpp:67:10: error: cannot convert 'const boost::scoped_ptr<boost::thread>' to 'bool' in return The patch does explicit conversion of boost::scoped_ptr to bool. Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@linux.intel.com>
|
Updated the type conversion to use static cast |
de-vri-es
approved these changes
Jan 26, 2017
|
Thanks for working on these details |
This was referenced Mar 5, 2017
|
PRs opened for J/K |
This was referenced Mar 16, 2017
JafarAbdi
pushed a commit
to JafarAbdi/moveit
that referenced
this pull request
Mar 24, 2022
Co-authored-by: AndyZe <zelenak@picknik.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With gcc6, compiling fails with
stdlib.h: No such file or directory,as including '-isystem /usr/include' breaks with gcc6, cf.,
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129.
This commit addresses this issue for this package in almost the same way
it was addressed in various other ROS packages. A list of related
commits and pull requests is at:
Particularly when searching for the Boost library CMake sets
Boost_INCLUDE_DIRS to @sysRoot@/usr/include which should be
avoided in the
-isystemoption of gcc.The same goes for OpenCV.
Fortunately neither Boost nor OpenCV trigger build warnings when their include dirs are not marked as system ones.