Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish robot description config #1265

Merged
merged 1 commit into from
May 19, 2022

Conversation

tylerjw
Copy link
Member

@tylerjw tylerjw commented May 19, 2022

  • Add options to config for publishing description
  • Fix clang-format-12 errors

This fix adds support to moveit_config_utils for the two parameters that determine if the robot description is published on a latched topic. This is useful for reducing the amount of boilerplate in launch files and in some cases making so some launch files don't need to be written at all.

This change is necesary for keeping the tutorials I am writing simple.

I also included two changes from running clang-format-12 over moveit in this. I've tested this change on 22.04 on Rolling.

Description

Please explain the changes you made, including a reference to the related issue if applicable

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference

Signed-off-by: Tyler Weaver <tyler@picknik.ai>
@tylerjw
Copy link
Member Author

tylerjw commented May 19, 2022

I don't understand how this is failing clang-format as I am using clang-format-12 locally. I will drop the commit that makes the changes that clang-format is complaining about.

@tylerjw tylerjw force-pushed the publish_robot_description_config branch from 960acdc to c080f3e Compare May 19, 2022 21:03
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #1265 (960acdc) into main (11d83b7) will not change coverage.
The diff coverage is n/a.

❗ Current head 960acdc differs from pull request most recent head c080f3e. Consider uploading reports for the commit c080f3e to get more accurate results

@@           Coverage Diff           @@
##             main    #1265   +/-   ##
=======================================
  Coverage   61.44%   61.44%           
=======================================
  Files         274      274           
  Lines       24936    24936           
=======================================
  Hits        15319    15319           
  Misses       9617     9617           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11d83b7...c080f3e. Read the comment docs.

@tylerjw tylerjw merged commit 3aef089 into moveit:main May 19, 2022
@tylerjw tylerjw deleted the publish_robot_description_config branch May 19, 2022 21:21
@DLu
Copy link
Contributor

DLu commented Jun 2, 2022

This broke the MSA demo. Can you show me the tutorial?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants