Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed C-style cast to C++-style cast for void data type #2010

Merged
merged 1 commit into from
Mar 13, 2023
Merged

Changed C-style cast to C++-style cast for void data type #2010

merged 1 commit into from
Mar 13, 2023

Conversation

Shobuj-Paul
Copy link
Contributor

@Shobuj-Paul Shobuj-Paul commented Mar 11, 2023

Description

Changed C-style cast to C++-style cast for the main branch. Implemented for void data type.
Changed (data_type)(expression) to static_cast<data_type>(expression) in multiple files and tested by building the packages via colcon.

Fixes #862

Checklist

@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Patch coverage: 75.00% and no project coverage change.

Comparison is base (0f47f28) 50.16% compared to head (b4303b9) 50.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2010      +/-   ##
==========================================
- Coverage   50.16%   50.15%   -0.00%     
==========================================
  Files         374      374              
  Lines       31352    31352              
==========================================
- Hits        15724    15721       -3     
- Misses      15628    15631       +3     
Impacted Files Coverage Δ
...it/collision_detection/test_collision_common_pr2.h 100.00% <ø> (ø)
.../collision_detection_fcl/src/collision_env_fcl.cpp 91.52% <ø> (ø)
...ion_bullet/src/bullet_integration/bullet_utils.cpp 64.65% <75.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sjahr sjahr merged commit 5f0eed4 into moveit:main Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use C++-style cast instead of C-style cast
2 participants