Cleanup to ros_control_interface and trajectory execution #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanie-eng
commented
May 29, 2023
| @@ -243,7 +243,6 @@ class Ros2ControlManager : public moveit_controller_manager::MoveItControllerMan | |||
| Ros2ControlManager() | |||
| : loader_("moveit_ros_control_interface", "moveit_ros_control_interface::ControllerHandleAllocator") | |||
| { | |||
| RCLCPP_INFO_STREAM(LOGGER, "Started moveit_ros_control_interface::Ros2ControlManager for namespace " << ns_); | |||
There was a problem hiding this comment.
I moved this to the other constructor that takes ns as an argument, because it looks like if using this constructor, ns_ would always be an empty string. That makes this print statement not very useful.
stephanie-eng
force-pushed
the
seng/controller_cleanup
branch
from
fe4dace
to
57f353f
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2208 +/- ##
==========================================
- Coverage 50.54% 50.52% -0.01%
==========================================
Files 386 386
Lines 31736 31736
==========================================
- Hits 16037 16031 -6
- Misses 15699 15705 +6 ☔ View full report in Codecov by Sentry. |
JafarAbdi
approved these changes
May 29, 2023
vatanaksoytezer
approved these changes
May 30, 2023
sjahr
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix some comments, variable naming, documentation, etc. in moveit_ros_control_interface and trajectory execution