Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix move_group capabilities loading #2270

Merged
merged 2 commits into from Jul 24, 2023
Merged

fix move_group capabilities loading #2270

merged 2 commits into from Jul 24, 2023

Conversation

todoubaba
Copy link
Contributor

@todoubaba todoubaba commented Jul 21, 2023

Description

Fix loading multi planners capabilities

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@sjahr
Copy link
Contributor

sjahr commented Jul 21, 2023

@todoubaba Thanks for the fix! To make CI happy please run pre-commit to format the code

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (b0f0f68) 50.50% compared to head (2c83021) 50.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2270      +/-   ##
==========================================
+ Coverage   50.50%   50.51%   +0.02%     
==========================================
  Files         386      386              
  Lines       31732    31732              
==========================================
+ Hits        16022    16026       +4     
+ Misses      15710    15706       -4     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JafarAbdi
Copy link
Contributor

lgtm. This doesn't fix the issue linked, though! That one should be handled from the python side!

@sjahr sjahr merged commit 6eebe6c into moveit:main Jul 24, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants