Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced boost::algorithm::join with fmt::join #2273

Merged
merged 5 commits into from Aug 12, 2023
Merged

Replaced boost::algorithm::join with fmt::join #2273

merged 5 commits into from Aug 12, 2023

Conversation

Shobuj-Paul
Copy link
Contributor

Description

This PR replaces boost::algorithm::join with fmt::join for string formatting to reduce boost dependencies.
Fixes #2227

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 40.00% and project coverage change: -0.03% ⚠️

Comparison is base (4476fb6) 50.72% compared to head (c9609e4) 50.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2273      +/-   ##
==========================================
- Coverage   50.72%   50.68%   -0.03%     
==========================================
  Files         386      386              
  Lines       31914    31914              
==========================================
- Hits        16184    16173      -11     
- Misses      15730    15741      +11     
Files Changed Coverage Δ
...include/moveit_setup_app_plugins/launch_bundle.hpp 0.00% <0.00%> (ø)
...ework/include/moveit_setup_framework/templates.hpp 25.00% <ø> (ø)
...sistant/moveit_setup_framework/src/urdf_config.cpp 49.40% <0.00%> (ø)
...nning_scene_monitor/src/planning_scene_monitor.cpp 37.28% <100.00%> (ø)
...assistant/moveit_setup_framework/src/templates.cpp 67.86% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shobuj-Paul Shobuj-Paul closed this Aug 1, 2023
@Shobuj-Paul Shobuj-Paul reopened this Aug 1, 2023
@Shobuj-Paul Shobuj-Paul marked this pull request as ready for review August 1, 2023 17:14
@Shobuj-Paul
Copy link
Contributor Author

@sjahr
I have made all the suggested changes, but moveit_setup_framework doesn't seem to pass clang tidy check. Could you please let me know where I am going wrong?

@sjahr
Copy link
Contributor

sjahr commented Aug 2, 2023

Thank you! This CI failure is not caused by your changes, you can ignore it 👍

@sjahr sjahr requested review from tylerjw and JafarAbdi August 2, 2023 07:02
Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! I still have to test it. Can we remove the Boost dependency in some CMakeLists.txt or package.xml files?

@@ -65,7 +66,7 @@ target_link_libraries(move_group moveit_move_group_capabilities_base)

add_executable(list_move_group_capabilities src/list_capabilities.cpp)
ament_target_dependencies(list_move_group_capabilities ${THIS_PACKAGE_INCLUDE_DEPENDS} Boost)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the Boost dependency still required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this particular node, I have removed it in the latest commit.

Copy link
Contributor

@sea-bass sea-bass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Would be nice to also be able to remove the boost::algorithm::trim() calls in planning_scene.cpp, but there doesn't seem to be an easy alternative.

Copy link
Contributor

@uavster uavster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjahr sjahr enabled auto-merge (squash) August 11, 2023 11:13
@mergify
Copy link

mergify bot commented Aug 12, 2023

This pull request is in conflict. Could you fix it @Shobuj-Paul?

@sjahr sjahr merged commit bdc9cec into moveit:main Aug 12, 2023
7 of 8 checks passed
@Shobuj-Paul Shobuj-Paul deleted the fmt_join branch August 13, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce dependency on boost by replacing boost::algorithm::join
4 participants