Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PSM] Get the parameter values of the main node when declaring them in the private node. #2392

Merged
merged 7 commits into from Sep 29, 2023

Conversation

JensVanhooydonck
Copy link
Contributor

Description

When creating the PlanningSceneMonitor a private node is created. (This was done here: #266)
This however doesn't use the declared parameters in the main node.

I added a check if the parameters exist and updated the default value of the parameter in the private node to this value.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (276e661) 50.76% compared to head (6df2e06) 50.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2392      +/-   ##
==========================================
+ Coverage   50.76%   50.78%   +0.02%     
==========================================
  Files         386      386              
  Lines       31972    31987      +15     
==========================================
+ Hits        16228    16241      +13     
- Misses      15744    15746       +2     
Files Coverage Δ
...nning_scene_monitor/src/planning_scene_monitor.cpp 37.74% <77.28%> (+0.47%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjahr sjahr enabled auto-merge (squash) September 29, 2023 07:07
@sjahr sjahr merged commit 5ab9305 into moveit:main Sep 29, 2023
7 of 8 checks passed
m-elwin pushed a commit to m-elwin/moveit2 that referenced this pull request Dec 4, 2023
…n the private node. (moveit#2392)

* Get the values of the main node when declaring them in the private node.

* [chore] linting

* Removed logging

* Update formatting

* Removed whitespace

---------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants