Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logging levels in servo logs #2440

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Fix logging levels in servo logs #2440

merged 1 commit into from
Oct 11, 2023

Conversation

sea-bass
Copy link
Contributor

We were getting spammed by the servo velocity scaling factor because something was using RCLCPP_WARN instead of RCLCPP_DEBUG.

Decided to comb through the Servo code and change other possible logging levels that.

@sea-bass sea-bass self-assigned this Oct 11, 2023
@sea-bass sea-bass requested review from eholum and sjahr October 11, 2023 20:54
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e7577ca) 50.37% compared to head (686cad7) 50.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2440      +/-   ##
==========================================
+ Coverage   50.37%   50.86%   +0.50%     
==========================================
  Files         385      386       +1     
  Lines       31829    32000     +171     
==========================================
+ Hits        16031    16275     +244     
+ Misses      15798    15725      -73     
Files Coverage Δ
moveit_ros/moveit_servo/src/utils/command.cpp 70.28% <ø> (ø)
moveit_ros/moveit_servo/src/collision_monitor.cpp 90.20% <0.00%> (+47.06%) ⬆️
moveit_ros/moveit_servo/src/servo.cpp 66.67% <50.00%> (+10.66%) ⬆️
moveit_ros/moveit_servo/src/servo_node.cpp 81.07% <0.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sea-bass sea-bass merged commit cc7a0d4 into main Oct 11, 2023
11 checks passed
@sea-bass sea-bass deleted the fix-servo-loggers branch October 11, 2023 21:37
MatthijsBurgh pushed a commit to MatthijsBurgh/moveit2 that referenced this pull request Oct 12, 2023
m-elwin pushed a commit to m-elwin/moveit2 that referenced this pull request Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants