Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong rename of set_start_state in 63e0c3a #2497

Merged
merged 1 commit into from Oct 30, 2023

Conversation

JensVanhooydonck
Copy link
Contributor

Description

In 63e0c3a the name of set_start_state was changed to set_goal_state.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (73f4551) 50.40% compared to head (871e448) 50.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2497      +/-   ##
==========================================
+ Coverage   50.40%   50.81%   +0.42%     
==========================================
  Files         391      392       +1     
  Lines       31982    32154     +172     
==========================================
+ Hits        16117    16336     +219     
+ Misses      15865    15818      -47     

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, thanks for fixing it!

@sjahr sjahr merged commit 87e3f91 into moveit:main Oct 30, 2023
12 checks passed
@peterdavidfagan
Copy link
Contributor

peterdavidfagan commented Oct 30, 2023

Thanks @JensVanhooydonck and @sjahr.

peterdavidfagan pushed a commit to peterdavidfagan/moveit2 that referenced this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants