Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid calling static node's destructor. #2513

Merged
merged 1 commit into from Nov 7, 2023
Merged

Avoid calling static node's destructor. #2513

merged 1 commit into from Nov 7, 2023

Conversation

uavster
Copy link
Contributor

@uavster uavster commented Nov 7, 2023 •
edited

Description

This PR replaces the global logger's static node with a static pointer to the node, thus avoiding the call to the node's destructor, which was making tests fail at tear-down.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@tylerjw tylerjw marked this pull request as ready for review November 7, 2023 14:26
@tylerjw tylerjw merged commit e880259 into moveit:main Nov 7, 2023
11 checks passed
tylerjw added a commit that referenced this pull request Nov 9, 2023
@tylerjw
Revert "Avoid calling static node's destructor. (#2513)"
076884b 
This reverts commit e880259.
@tylerjw tylerjw mentioned this pull request Nov 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerjw tylerjw tylerjw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@uavster @tylerjw