Remember original color of objects in planning scene #2549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2549 +/- ##
==========================================
- Coverage 50.86% 50.52% -0.33%
==========================================
Files 388 387 -1
Lines 32260 32099 -161
==========================================
- Hits 16405 16216 -189
- Misses 15855 15883 +28 ☔ View full report in Codecov by Sentry. |
sjahr
reviewed
Nov 27, 2023
moveit_core/planning_scene/include/moveit/planning_scene/planning_scene.h
Show resolved
Hide resolved
sea-bass
force-pushed
the
remember-planning-scene-obj-color
branch
from
d62f1ca
to
41bb82b
Compare
sea-bass
force-pushed
the
remember-planning-scene-obj-color
branch
from
41bb82b
to
60bc14f
Compare
sjahr
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a mechanism for the planning scene to remember objects' original colors when first added, which helps restore colors to the original when attaching/detaching in RViz.
See the video below. Prior to this PR, the blue object would have turned green when being placed.
planning_scene_object_color_10x.mp4