Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PSM] Process collision object color when adding object trough the planning scene monitor #2567

Conversation

JensVanhooydonck
Copy link
Contributor

Added an optional collision object color object to the processCollisionObjectMsg call. This allows will apply the color to the planning scene and make sure this is also synced when publishing a diff planning scene.

Description

Added an optional color_msg to the processCollisionObjectMsg in the Planning scene monitor.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

…the collision object when adding the collision object trough the PSM.
Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (0d2d070) 50.47% compared to head (673cb5d) 50.91%.

Files Patch % Lines
...nning_scene_monitor/src/planning_scene_monitor.cpp 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2567      +/-   ##
==========================================
+ Coverage   50.47%   50.91%   +0.44%     
==========================================
  Files         386      387       +1     
  Lines       32228    32430     +202     
==========================================
+ Hits        16265    16507     +242     
+ Misses      15963    15923      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjahr
Copy link
Collaborator

sjahr commented Dec 7, 2023

@sjahr sjahr enabled auto-merge (squash) January 3, 2024 11:07
auto-merge was automatically disabled January 6, 2024 09:57

Head branch was pushed to by a user without write access

@JensVanhooydonck
Copy link
Contributor Author

@sjahr Sorry for the delay. Fixed it now.

@sjahr sjahr enabled auto-merge (squash) January 8, 2024 12:38
@sjahr sjahr merged commit 4bcbac7 into moveit:main Jan 8, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants