Replace all single-character strings with chars #2892
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
EzraBrooks
force-pushed
the
replace-all-single-character-string-with-char
branch
2 times, most recently
from
4caec2b
to
1d85309
Compare
EzraBrooks
commented
Jun 28, 2024
| @@ -193,7 +193,7 @@ void computeDB(const rclcpp::Node::SharedPtr& node, const planning_scene::Planni | |||
| * y: [0.2, 0.3] | |||
| * z: [0.1, 0.6] | |||
| * weight: 1.0 | |||
| * """ | |||
| * '"' | |||
There was a problem hiding this comment.
Is this a Python docstring embedded in a C++ comment? Should this be triple backticks or something?
EzraBrooks
force-pushed
the
replace-all-single-character-string-with-char
branch
from
1d85309
to
2f49b95
Compare
|
There appear to be some load-bearing single-character strings in MoveIt - I guess I am yet another developer brought low by this ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Was looking for something quick to do between tickets. Closes #871.
Regexes are your friend!
Checklist