This repository has been archived by the owner on Nov 13, 2017. It is now read-only.
New getOnlyOneEndEffectorTip() function #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const moveit::core::LinkModel* getOnlyOneEndEffectorTip() const; | ||
|
|
||
| /** \brief If this group is an end-effector, specify the foot type (if any, may be NONE) */ | ||
| void setEndEffectorFootType(const JointModelGroupFootType &end_effector_foot_type); |
There was a problem hiding this comment.
Am I missing something or is this additional function declared here without any implementation?
There was a problem hiding this comment.
ooops, yes, that is part of my research code that leaked into this PR during a merge
|
ping can this be merged in? |
|
+1 lgtm I cannot test on jade, yet. So, you can merge yourself, if you can ensure it works correctly. Otherwise I'll get to it soon. |
|
Thanks for looking at it. However, we've a rule to not merge our own PRs |
|
Tested and works. Thanks. |
dornhege
added a commit
that referenced
this pull request
Dec 8, 2015
New getOnlyOneEndEffectorTip() function
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you want to quickly solve a IK problem on the tip link of a joint model group using its end effector semantics, this is a helpful shortcut function