-
Notifications
You must be signed in to change notification settings - Fork 76
[reopen] Upgrade to Eigen3 as required in Jade #293
[reopen] Upgrade to Eigen3 as required in Jade #293
Conversation
Ping @davetcoleman or anyone who's interested. Thanks! |
@130s Is https://goo.gl/hNNKD1 the recommended way to fix issues with finding Eigen3 on OSX? From my understanding this issue is not yet resolved, is it? |
# Eigen3 hack for Jade http://wiki.ros.org/jade/Migration#Eigen_CMake_Module_in_cmake_modules | ||
find_package(Eigen3) | ||
find_package(PkgConfig) | ||
pkg_search_module(Eigen3 REQUIRED eigen3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand how this hack is the same as the one in the link you reference, they look pretty different to me.
@rhaschke @davetcoleman yeah I'm not sure whether this PR that got a hint from https://goo.gl/hNNKD1 that uses |
I looked into that issue a little bit deeper: One issue is that On the other hand, finding However, case matters! The line should be changed to Anyway, in the moveit_core package, Eigen3 doesn't need to be pulled in explicitly, because it catkin-depends on I rebased @130s' branch to |
9ea7d1f
to
56a56d0
Compare
56a56d0
to
69e12f9
Compare
@rhaschke thanks for the deeper look. I cherry-picked your commits into this PR, and squashed a little bit (I still left 3 commits to show all the committers who contributed). |
LGTM. |
@130s Can you adapt the other MoveIt repos in a similar fashion? |
Replacing #290
@davetcoleman I confirmed that this works. Tried to open PR against your branch but it seems out of date so I might as well open a new one here.