Skip to content
This repository has been archived by the owner on Nov 13, 2017. It is now read-only.

Remove PCL dependency #449

Closed
wants to merge 3 commits into from
Closed

Conversation

vrabaud
Copy link
Contributor

@vrabaud vrabaud commented Apr 16, 2014

No description provided.

* copyright notice, this list of conditions and the following
* disclaimer in the documentation and/or other materials provided
* with the distribution.
* * Neither the name of Willow Garage, Inc. nor the names of its
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct license information

@isucan
Copy link
Contributor

isucan commented Apr 17, 2014

+1
Vincent, thanks for the patch. Should the iterator stuff be a separate package?

@vrabaud
Copy link
Contributor Author

vrabaud commented Apr 18, 2014

ok, I fixed the licenses.
Those files are in sensor_msgs in Indigo but will not be backported to hydro according to ros/common_msgs#16, hence the copy.

@davetcoleman
Copy link
Member

@vrabaud it looks like the repo is out of sync with this PR, could you try updating it to the latest hydro-devel?

is there some other reason this has not been merged yet?

@vrabaud
Copy link
Contributor Author

vrabaud commented Sep 7, 2014

Hey, the Travis job passed. Now, I copied the PointCloud2 iterators over so that it also works in Hydro. I see that you have branched moveit_core for Indigo. Are you going to do the same for moveit_ros ? In which case I would simpify my PR and only make it for Indigo.

@isucan
Copy link
Contributor

isucan commented Sep 7, 2014

I think we should branch for indigo.
On Sep 7, 2014 12:31 PM, "Vincent Rabaud" notifications@github.com wrote:

Hey, the Travis job passed. Now, I copied the PointCloud2 iterators over
so that it also works in Hydro. I see that you have branched moveit_core
for Indigo. Are you going to do the same for moveit_ros ? In which case I
would simpify my PR and only make it for Indigo.


Reply to this email directly or view it on GitHub
#449 (comment)
.

@vrabaud
Copy link
Contributor Author

vrabaud commented Sep 7, 2014

Then please do and I'll make my PR there. Thx.

@davetcoleman
Copy link
Member

I have branched moveit_ros for indigo as requested:
https://github.com/ros-planning/moveit_ros/tree/indigo-devel

Now that moveit_core, moveit_ros, and moveit_planners are branched, I vote we set them as the default github branches. Anyone opposed?

@isucan
Copy link
Contributor

isucan commented Sep 8, 2014

+1 for default branch
On Sep 8, 2014 6:03 PM, "Dave Coleman" notifications@github.com wrote:

I have branched moveit_ros for indigo as requested:
https://github.com/ros-planning/moveit_ros/tree/indigo-devel

Now that moveit_core, moveit_ros, and moveit_planners are branched, I vote
we set them as the default github branches. Anyone opposed?


Reply to this email directly or view it on GitHub
#449 (comment)
.

@vrabaud
Copy link
Contributor Author

vrabaud commented Sep 8, 2014

thx, closing that in favor of #490

@vrabaud vrabaud closed this Sep 8, 2014
@davetcoleman
Copy link
Member

moveit_core, moveit_ros, and moveit_planners now default to the indigo branch

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants