Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix marker creation: allow zero scale for geometric shapes #430

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

rhaschke
Copy link
Contributor

  • Link geometries like boxes, spheres, and cylinders might explicitly have a zero size. Don't reset their scale to (1,1,1)!
    Instead initialize a correct scaling by other means.
  • As zero-size markers will be invisible, drop them from the generated marker arrays.

Boxes, spheres, cylinders might explicitly have a zero size.
Don't reset this scaling to (1,1,1)!
@codecov
Copy link

codecov bot commented Feb 19, 2023

Codecov Report

Base: 58.85% // Head: 58.85% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (f45e355) compared to base (eae0bdc).
Patch coverage: 20.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #430      +/-   ##
==========================================
- Coverage   58.85%   58.85%   -0.00%     
==========================================
  Files          89       89              
  Lines        8386     8387       +1     
==========================================
  Hits         4935     4935              
- Misses       3451     3452       +1     
Impacted Files Coverage Δ
rviz_marker_tools/src/marker_creation.cpp 29.37% <0.00%> (-0.27%) ⬇️
core/src/marker_tools.cpp 68.19% <50.00%> (-0.42%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rhaschke rhaschke merged commit ea776e3 into moveit:master Feb 23, 2023
@rhaschke rhaschke deleted the fix-marker-creation branch February 23, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant