Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed deprecated call to PlanningSceneMonitor's constructor #108

Merged
merged 3 commits into from
Nov 30, 2021

Conversation

stephanie-eng
Copy link
Contributor

Fixes the warnings when building from #107

Copy link

@vatanaksoytezer vatanaksoytezer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it @stephanie-eng! One small nit below, do you mind trying that as well?

src/moveit_visual_tools.cpp Outdated Show resolved Hide resolved
@henningkayser
Copy link
Member

@stephanie-eng what's the state of this PR? seems like there are still some issues to resolve

@henningkayser henningkayser merged commit 5b98097 into moveit:ros2 Nov 30, 2021
@stephanie-eng stephanie-eng deleted the deprecated-fix branch November 30, 2021 19:54
@markusbuchholz
Copy link

I have just installed ROS2 foxy (on Ubuntu 20.04 also installed just before )and unfortunately I struggled with regarding issue. In order to go further I just commend the line so I could complete build. This is only information since I do not not yet how important described issue is. Thank you!

@vatanaksoytezer
Copy link

vatanaksoytezer commented Dec 6, 2021

Hello @markusbuchholz thanks for reporting! Are you using the foxy branch (https://github.com/ros-planning/moveit_visual_tools/tree/foxy) of this repository? I can't reproduce what you are seeing neither in my local setup or in CI (https://github.com/ros-planning/moveit_visual_tools/runs/4291381993?check_suite_focus=true).

@markusbuchholz
Copy link

Hello @vatanaksoytezer . Yes I installed great foxy however I can install the latest version. Brilliant Moveit 2 I installed just after the foxy and Ubuntu 20.04. (fresh systems). As I mentioned my issue can be handled as information only since I could complete building OK (however by isolating/commented discussing line of code) . Not sure about the latest ROS2. I suppose it is OK. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants