Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compile with -std=c++11 #29

Merged
merged 1 commit into from
Jan 30, 2017
Merged

Compile with -std=c++11 #29

merged 1 commit into from
Jan 30, 2017

Conversation

vmatare
Copy link
Contributor

@vmatare vmatare commented Jan 26, 2017

No description provided.

@de-vri-es
Copy link

Should be fine I think, but I wonder, did something break without the flag?

@vmatare
Copy link
Contributor Author

vmatare commented Jan 30, 2017 •
edited
Loading

urdfdom_headers switched from boost::shared_ptr to std::shared_ptr in #729c4de, so if we compile against it, we need C++11.

de-vri-es
de-vri-es approved these changes Jan 30, 2017
View reviewed changes
Copy link

@de-vri-es de-vri-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, makes sense. Looks good to me.

@v4hn
Copy link
Contributor

v4hn commented Jan 30, 2017

Thanks @vmatare !

@v4hn v4hn merged commit 0aceecb into moveit:kinetic-devel Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v4hn v4hn v4hn approved these changes

@de-vri-es de-vri-es de-vri-es approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vmatare @de-vri-es @v4hn