Change log{Error,Warn} -> CONSOLE_BRIDGE_log{Error,Warn} #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
log{Error,Warn} were deprecated and removed in Melodic.
Switch to the supported CONSOLE_BRDIGE_log{Error,Warn}.
Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
|
Thanks a lot! |
|
When you get a chance, a new release into Melodic should hopefully make the buildfarm happy. Thanks. |
|
@130s, can you take care of the release or grant permissions to me? |
|
I'm afraid I don't have adimn right. @wjwwood could you? |
|
@rhaschke added as collaborator to https://github.com/ros-gbp/srdfdom-release |
|
Done: ros/rosdistro#17600 |
|
Fantastic, looks like it is happier now. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log{Error,Warn} were deprecated and removed in Melodic.
Switch to the supported CONSOLE_BRDIGE_log{Error,Warn}.
Signed-off-by: Chris Lalancette clalancette@openrobotics.org
I'll note that this can also be pushed to the kinetic-devel branch, since the CONSOLE_BRIDGE macros exist there as well.