Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2/Tinyxml2 updates #52

Merged
merged 5 commits into from
Jan 13, 2020
Merged

ROS2/Tinyxml2 updates #52

merged 5 commits into from
Jan 13, 2020

Conversation

pbeeson
Copy link

@pbeeson pbeeson commented Dec 23, 2019

Updates needed for ros2 compile (tested under eloquent) and tinyxml2.

find_package(Boost REQUIRED)
# Default to C++14
if(NOT CMAKE_CXX_STANDARD)
set(CMAKE_CXX_STANDARD 14)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may also want to set these related flags:

set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_EXTENSIONS OFF)

@henningkayser
Copy link
Member

@pbeeson Thanks a lot for preparing this! I've created a PR for your feature branch with some changes that should fix CI warnings (jdlangs#1). Please review/merge and then squash the commit history into meaningful chunks (i.e. code migration, update CMakeLists.txt/package.xml, etc...)

@pbeeson
Copy link
Author

pbeeson commented Dec 31, 2019

@henningkayser Done.

@henningkayser
Copy link
Member

@pbeeson thanks for merging. It looks like urdfdom_py is still missing. I created a new ROS 2 port of that which should get merged first in order to get CI to succeed. We'll need to add a rosinstall for that.

@henningkayser henningkayser merged commit e6af272 into moveit:ros2 Jan 13, 2020
@henningkayser
Copy link
Member

@pbeeson thanks

@rhaschke rhaschke mentioned this pull request Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants