Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis for noetic #57

Merged
merged 5 commits into from
Jun 30, 2020
Merged

Travis for noetic #57

merged 5 commits into from
Jun 30, 2020

Conversation

v4hn
Copy link
Contributor

@v4hn v4hn commented Apr 2, 2020

Currently, this fails.
But if somebody adjusts the moveit_ci infrastructure, here is the patch to test it already.

@rhaschke
Copy link
Contributor

rhaschke commented Apr 2, 2020

Do we really need a separate branch for noetic already? Let's try to postpone creation of new branches a long as possible. Otherwise we end up in a cherry-pick mess as in the main MoveIt repo.

@ahcorde
Copy link
Contributor

ahcorde commented Apr 3, 2020

@ros-pull-request-builder retest this please

@ahcorde
Copy link
Contributor

ahcorde commented Apr 3, 2020

CI is returning a Warning http://build.ros.org/job/Npr__srdfdom__ubuntu_focal_amd64/1/

08:51:46 CMake Warning at CMakeLists.txt:61 (message):
08:51:46   Locale nl_NL not available.  Locale test will not be meaningful.

https://github.com/ros-planning/srdfdom/blob/0232a1691a68fee4e90ad12ea6751175c8d1ad6b/CMakeLists.txt#L57-L62

Any thoughts?

@rhaschke
Copy link
Contributor

rhaschke commented Apr 3, 2020

This test requires the NL locale to be installed, which we do in our Travis CI. This is all fine.

@rhaschke rhaschke closed this Jun 29, 2020
@rhaschke
Copy link
Contributor

Trigger CI.

@rhaschke rhaschke reopened this Jun 29, 2020
@rhaschke rhaschke changed the base branch from noetic-devel to melodic-devel June 29, 2020 23:57
@rhaschke rhaschke merged commit 37db434 into moveit:melodic-devel Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants