Move console_bridge_LIBRARIES to target_link_libraries #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got the following error when building with Foxy on Ubuntu 20.04.
```
--- stderr: srdfdom
CMake Error at /home/allenh1/ros2_ws/install/ament_cmake_target_dependencies/share/ament_cmake_target_dependencies/cmake/ament_target_dependencies.cmake:66 (message):
ament_target_dependencies() the passed package name
'console_bridge::console_bridge' was not found before
Call Stack (most recent call first):
CMakeLists.txt:42 (ament_target_dependencies)
```
To fix this, I moved the `${console_bridge_LIBRARIES}` dependency to the `target_link_libraries`, since it is a system library.
|
@allenh1 thanks, I just wanted to fix the same thing. Wouldn't it work to directly list |
|
@henningkayser yeah, that should also work. I can change it if that way is preferred. |
Yeah, I think that would be the preferred way to do it. Thanks |
Signed-off-by: Hunter L. Allen <hunter.allen@ghostrobotics.io>
|
@henningkayser should be good now, builds on my machine :) |
henningkayser
approved these changes
Jun 24, 2020
|
thanks @allenh1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got the following error when building with Foxy on Ubuntu 20.04.
To fix this, I moved the
${console_bridge_LIBRARIES}dependency to thetarget_link_libraries, since it is a system library.