Switch from TinyXML to TinyXML2 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing and reopening to trigger Travis. |
8 tasks
|
Is there any reason we shouldn't do this? It seems like a good thing to depend on the new/maintained version of libraries. |
tylerjw
approved these changes
Aug 19, 2020
There was a problem hiding this comment.
This looks like a really straightforward adaptation to the newer library. I don't see any downsides to this change. It will need to be rebased after the clang-format-10 change. I'm sorry about that.
I think we should maybe disable (or quiet) the Jenkins tests since we have Travis.
davetcoleman
approved these changes
Aug 19, 2020
There was a problem hiding this comment.
@rojkov's original rationale for updating makes sense to me:
The library TinyXML is considered to be unmaintained and since all future development is focused on TinyXML2 this patch updates srdfdom to use TinyXML2.
The library TinyXML is considered to be unmaintained and since all future development is focused on TinyXML2 this patch updates srdfdom to use TinyXML2. Signed-off-by: Dmitry Rozhkov <dmitry.rozhkov@linux.intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase of #32, which was postponed for integration into Noetic (due to API changes).
As both, urdf and urdfdom still depend on TinyXML, I'm not sure it's worth the effort to make the transition here - unfortunately.