-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unit tests & setup.py file #94
Conversation
@ooeygui Could you please test/review this PR .? |
Codecov Report
@@ Coverage Diff @@
## ros2 #94 +/- ##
=======================================
Coverage 68.21% 68.21%
=======================================
Files 3 3
Lines 607 607
=======================================
Hits 414 414
Misses 193 193 Continue to review full report at Codecov.
|
Thank you for the quick turnaround - testing now |
Confirmed working on ubuntu. |
Looks like the Windows release hasn't caught up with the pytest issues, so I had to manually revert Looks like we're missing some exports for Windows when building. Taking a look.
|
Look like these errors should be fixed in #91, have you tried rebasing on it.? |
@JafarAbdi Ack! I thought I cherry-picked your change into a fixed branch - checking now. |
I can confirm that this change works for Windows and Linux! Thank you for fixing this @JafarAbdi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Fix: #92
Fix: #93